Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): add emits.error declaration to NuxtErrorBoundary component #6141

Merged
merged 1 commit into from
Jul 26, 2022
Merged

fix(nuxt): add emits.error declaration to NuxtErrorBoundary component #6141

merged 1 commit into from
Jul 26, 2022

Conversation

hecateball
Copy link
Contributor

πŸ”— Linked issue

nuxt/nuxt#14402 Get warning when v-on:error event handler is set to NuxtErrorBoundary

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

add emits.error declaration to NuxtErrorBoundary to prevent prevent getting warning message.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Jul 26, 2022

βœ… Deploy Preview for nuxt3-docs ready!

Name Link
πŸ”¨ Latest commit 0162a9c
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62df8e6549d73b0008196fca
😎 Deploy Preview https://deploy-preview-6141--nuxt3-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch and solution πŸ‘Œ

@pi0 pi0 merged commit e08a493 into nuxt:main Jul 26, 2022
@pi0 pi0 mentioned this pull request Aug 5, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants