Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

feat(test-utils): add mockFn and mockLogger utils #6235

Merged
merged 15 commits into from
Sep 5, 2022
Merged

feat(test-utils): add mockFn and mockLogger utils #6235

merged 15 commits into from
Sep 5, 2022

Conversation

ricardogobbosouza
Copy link
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Add mockLogger used in module testing

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Jul 29, 2022 •
edited
Loading

✅ Deploy Preview for nuxt3-docs ready!

Name Link
🔨 Latest commit a72b345
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6315b0ef2937a20008145577
😎 Deploy Preview https://deploy-preview-6235--nuxt3-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ricardogobbosouza ricardogobbosouza changed the title feat(test-utils): add mocks feat(test-utils): add mockLogger Jul 29, 2022
@ricardogobbosouza ricardogobbosouza changed the title feat(test-utils): add mockLogger feat(test-utils): add mocks Jul 29, 2022
@pi0 pi0 changed the title feat(test-utils): add mocks feat(test-utils): add mockFn and mockLogger utils Aug 23, 2022
pi0
pi0 approved these changes Sep 5, 2022
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice initiative! Thanks (i didn't well tested this addition with latest changes. please feel free to make pr if have any issues)

@pi0 pi0 merged commit b31405f into nuxt:main Sep 5, 2022
@ricardogobbosouza
Copy link
Contributor Author

Nice @pi0

This was referenced Sep 9, 2022
Merged
Merged
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danielroe danielroe danielroe left review comments

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ricardogobbosouza @pi0 @danielroe