Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

Add docker example #6780

Closed
wants to merge 1 commit into from
Closed

Add docker example #6780

wants to merge 1 commit into from

Conversation

HomWang
Copy link
Contributor

@HomWang HomWang commented Aug 19, 2022

Help users with docker deployment

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Help users with docker deployment
@netlify
Copy link

netlify bot commented Aug 19, 2022

βœ… Deploy Preview for nuxt3-docs ready!

Name Link
πŸ”¨ Latest commit 0da6d9b
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62ff63c00759f10008f4690d
😎 Deploy Preview https://deploy-preview-6780--nuxt3-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@danielroe
Copy link
Member

danielroe commented Aug 19, 2022

This is great - thank you!

We have currently not provided a Dockerfile in the docs so far with the aim of instead providing a Docker preset that could even generate a file for users. unjs/nitro#54. @pi0 would be better able to comment, but it's possible we might defer adding this to the docs until we have a first-class nitro docker preset.

In terms of feedback on the Dockerfile, I would also advise not including the ~/node_modules folder in the image but only ~/.output as it should have all its dependencies already installed there.

@HomWang
Copy link
Contributor Author

HomWang commented Aug 19, 2022

This is great - thank you!

We have currently not provided a Dockerfile in the docs so far with the aim of instead providing a Docker preset that could even generate a file for users. unjs/nitro#54. @pi0 would be better able to comment, but it's possible we might defer adding this to the docs until we have a first-class nitro docker preset.

In terms of feedback on the Dockerfile, I would also advise not including the ~/node_modules folder in the image but only ~/.output as it should have all its dependencies already installed there.

I commented on the dependency file. There may be users who want to use it. By default, no dependent files will appear. is used ~/.output file

@pi0
Copy link
Member

pi0 commented Aug 22, 2022

Thanks for PR @516310460 <3 As daniel mentioned, we might introduce docker preset with proper nitro support, multi-stage build and only including .output.

@pi0 pi0 closed this Aug 22, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants