This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt): load payload after middleware and once final route is resolved #7574
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
nuxt/nuxt#14927
β Type of change
π Description
This is not an alternative to #7567, but a separate fix. It ensures the data is only applied immediately before the route resolves (so after all middleware have been processed - and not when the data is prefetched)....
Where same asyncData keys are used for different routes (e.g. in a
[slug].vue
), this will resolve the issue, with one exception: if there are still additional async setups required and the keys collide.In some ways this mitigates nuxt/nuxt#14927 because data isn't overwritten when it is prefetched, but only when the route is changed.
Note: although it hotfixes content + prerender, we still would want to change content implementation as suspense doesn't work when swapping data out like this; instead, we want a route-based composable so that we can have two 'trees'. (useState doesn't work best when holding route-based data because it isn't naturally associated with a route... See nuxt/nuxt#14924.)
π Checklist