This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 1k
fix(vite): include id and stack in vite-node
fallback error handler
#7575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
added
dx
vite
π° p2-nice-to-have
Priority 2: nothing is broken but it's worth addressing
labels
Sep 15, 2022
β Deploy Preview for nuxt3-docs canceled.
|
pi0
reviewed
Sep 16, 2022
danielroe
commented
Sep 16, 2022
danielroe
changed the title
fix(vite): provide fallback stack + reason
fix(vite): provide fallback reason
Sep 16, 2022
I've made #7589 for a better normalization approach. I think we can change this PR to make fatal errors (unhandled while normalizing) to include module id in the message. But |
Sure π Also happy to close this and we can do it all in your linked PR. |
|
pi0
changed the title
fix(vite): provide fallback reason
fix(vite): include module id in Sep 16, 2022
vite-node
fallback errors
pi0
changed the title
fix(vite): include module id in
fix(vite): include id and stack in Sep 16, 2022
vite-node
fallback errorsvite-node
fallback error handler
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
ref nuxt/nuxt#14909
β Type of change
π Description
This adds more info in the event of minimal error data. In the linked issue, error data is:
That's enough to thwart our formatter.
This PR adds stack + reason fallbacks, transforming it to:
Admittedly probably the stack isn't helpful in this case, but at least the error message tells us the module that couldn't be fetched. Alternatively, maybe we could directly throw the error if we only have a
code
in errorData?π Checklist