This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(webpack): add global to new line #8226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
added
bug
|
|
✅ Deploy Preview for nuxt3-docs canceled.
|
pi0
approved these changes
Oct 16, 2022
pi0
reviewed
Oct 16, 2022
| @@ -21,7 +21,7 @@ export const DynamicBasePlugin = createUnplugin((options: DynamicBasePluginOptio | |||
| return | |||
| } | |||
| const s = new MagicString(code) | |||
| s.append(`${options.globalPublicPath} = buildAssetsURL();\n`) | |||
| s.append(`\n${options.globalPublicPath} = buildAssetsURL();\n`) | |||
There was a problem hiding this comment.
@antfu What do you think about supporting s.appendLine?
There was a problem hiding this comment.
We didn't have the concept of line in MagicString, as all operations are index based. I am not sure if this complexity is necessary, giving the fix here is straightforward, while on the other hand we might end up introduce the xxxLine version for every magic string methods.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
Previously we could end up with invalid JS and the following error:
📝 Checklist