Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

chore(nuxt): add type for headers #8326

Merged
merged 1 commit into from
Oct 19, 2022
Merged

chore(nuxt): add type for headers #8326

merged 1 commit into from
Oct 19, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • 🧹Chore
  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This casts incoming headers to HeadersInit and resolves lint issue. @pi0 can you confirm that this is valid (ie. that the actual type of these headers is assignable in fetch) or do we need to normalise them instead?

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from pi0 October 19, 2022 13:12
@danielroe danielroe self-assigned this Oct 19, 2022
@codesandbox
Copy link

codesandbox bot commented Oct 19, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Oct 19, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 35550ae
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/634ff7d69a28660007654798

@pi0
Copy link
Member

pi0 commented Oct 19, 2022

Added h3 improvement to normalize. Will improve after release. (unjs/h3@d141f81)

@pi0 pi0 merged commit 3333ef8 into main Oct 19, 2022
@pi0 pi0 deleted the chore/headers-type branch October 19, 2022 13:28
@pi0 pi0 mentioned this pull request Oct 19, 2022
7 tasks
@pi0 pi0 mentioned this pull request Nov 3, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants