Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

feat(nuxt-link): add isExternal to slot props #8800

Merged
merged 5 commits into from
Nov 9, 2022
Merged

feat(nuxt-link): add isExternal to slot props #8800

merged 5 commits into from
Nov 9, 2022

Conversation

manniL
Copy link
Member

@manniL manniL commented Nov 8, 2022

🔗 Linked issue

nuxt/nuxt#15398

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR exposes the isExternal scoped slot prop of <NuxtLink>

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link

codesandbox bot commented Nov 8, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Nov 8, 2022 •
edited
Loading

✅ Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit b89549d
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/636a25e0d7e5270008ad225e

@manniL @danielroe
Update packages/nuxt/src/app/components/nuxt-link.ts
b89549d 
Co-authored-by: Daniel Roe <daniel@roe.dev>
pi0
pi0 approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@pi0 pi0 merged commit 15d4cea into nuxt:main Nov 9, 2022
@pi0 pi0 mentioned this pull request Nov 9, 2022
Closed
4 tasks
@manniL manniL deleted the feat/nuxt-linkadd-is-external branch November 9, 2022 09:35
@pi0 pi0 mentioned this pull request Nov 15, 2022
Merged
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danielroe danielroe danielroe approved these changes

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manniL @pi0 @danielroe