This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
feat(nuxi): wrap and normalize all console outputs #8846
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
This PR uses
consola.wrapAll
instead ofconsola.wrapConsole
in order to intercept all console outputs. Code running in SSR worker, writes tostdout
andstderr
instead of (main process)console
object.Now, it is possible to use something like
console.log('Hello `123`')
from a Vue SFC to have beautiful output formatted by console:This way we can intercept console output and also improve DX for some known issues:
[Vue Router warn]: No match found for location with path'
node_modules
It is possible to also use vite's custom logger (probably other custom loggers including one for SSR) but i assume it is easier to manage console logging and filtering from one place. We made console for Nuxt 2 with this purpose.
π Checklist