This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt): allow directly rendering error page in dev #8850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for nuxt3-docs canceled.
|
|
Adding a direct render call was actually to fix an issue with the development template XSS only. #8884 should fixed linked issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves nuxt/nuxt#15362
❓ Type of change
📚 Description
We likely only need to protect against directly rendering the error page in production; this seems to cause issues in dev mode as it is triggered by
vite-nodeerrors.📝 Checklist