Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): preserve render errors #8884

Merged
merged 2 commits into from
Nov 10, 2022
Merged

fix(nuxt): preserve render errors #8884

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f1b230
fix(nuxt): preserve render errors
pi0 Nov 10, 2022
55607de
simplify logic
pi0 Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions packages/nuxt/src/core/runtime/nitro/renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,18 +171,13 @@ export default defineRenderHandler(async (event) => {
writeEarlyHints(event, link)
}

const _rendered = await renderer.renderToString(ssrContext).catch((err) => {
if (!ssrError) {
// Use explicitly thrown error in preference to subsequent rendering errors
throw ssrContext.payload?.error || err
}
const _rendered = await renderer.renderToString(ssrContext).catch((error) => {
// Use explicitly thrown error in preference to subsequent rendering errors
throw (!ssrError && ssrContext.payload?.error) || error
})
await ssrContext.nuxt?.hooks.callHook('app:rendered', { ssrContext })

// Handle errors
if (!_rendered) {
return undefined!
}
if (ssrContext.payload?.error && !ssrError) {
throw ssrContext.payload.error
}
Expand Down