This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: @vueuse/head
v1
#8908
Closed
feat: @vueuse/head
v1
#8908
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f72222a
feat: `@vueuse/head` next
harlan-zw e2de07b
chore: fix PR artifact
harlan-zw c2245d0
chore: fix PR artifact
harlan-zw 71a4a2b
chore: fix PR artifact
harlan-zw adb9960
chore: add @unhead/ssr as explicit dep
harlan-zw 8517567
chore: move @unhead/schema to a dep
harlan-zw e10b784
chore: sync lock file
harlan-zw f730b25
chore: fix broken type
harlan-zw 8062a00
Merge branch 'main' of github.com:nuxt/framework into feat/meta-modulβ¦
harlan-zw dc99d52
chore: bump @vueuse/head
harlan-zw d5ecce3
chore: fix build maybe
harlan-zw 0bf2cc9
chore: bump to @vueuse/head v1
harlan-zw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,5 @@ | ||
import type { UseHeadInput } from '@vueuse/head' | ||
import type { HeadAugmentations } from '@nuxt/schema' | ||
export * from './composables' | ||
export type { MetaObject } from '@nuxt/schema' | ||
|
||
export type MetaObject = UseHeadInput<HeadAugmentations> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,19 @@ | ||
export default defineNuxtConfig({ | ||
|
||
app: { | ||
head: { | ||
title: 'nuxt', | ||
meta: [ | ||
{ charset: 'utf-8' }, | ||
{ name: 'viewport', content: 'width=device-width, initial-scale=1' }, | ||
{ key: 'description', name: 'description', content: '' } | ||
], | ||
script: [ | ||
{ | ||
src: 'https://cdnjs.cloudflare.com/ajax/libs/Chart.js/2.9.4/Chart.min.js', | ||
body: true | ||
} | ||
], | ||
link: [{ rel: 'icon', type: 'image/x-icon', href: '/favicon.ico' }] | ||
} | ||
} | ||
}) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't figure out why this needed to be exposed by
@nuxt/schema
exactly. The reactive object is only passed used as an argument for theuseHead
function,nuxt.config.ts
uses the non-reactive schema.The nuxt app itself exposes it as well. If we remove it then we don't need to depend on import the full module for the types