Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): include layers in esbuild transform #9014

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

If we are using typescript files within a layer, esbuild doesn't process this and the nitro build will fail. This PR exempts layers from the node_modules exclude, but otherwise preserves it.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Nov 15, 2022
@danielroe danielroe requested review from atinux and pi0 November 15, 2022 13:45
@danielroe danielroe self-assigned this Nov 15, 2022
@codesandbox
Copy link

codesandbox bot commented Nov 15, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Nov 15, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 7fec6e0
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/637398131b2fcc000a00e7a0

@pi0 pi0 merged commit 4c8369f into main Nov 15, 2022
@pi0 pi0 deleted the fix/esbuild-layers branch November 15, 2022 13:52
@pi0 pi0 mentioned this pull request Nov 16, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants