Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migration to nuxt3 #96

Merged
merged 53 commits into from
Aug 3, 2022
Merged

feat: migration to nuxt3 #96

merged 53 commits into from
Aug 3, 2022

Conversation

antfu
Copy link
Member

@antfu antfu commented Apr 19, 2022

Progress

Preview: https://hackernews-git-nuxt3-nuxt-js.vercel.app/

@vercel
Copy link

vercel bot commented Apr 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
hackernews ✅ Ready (Inspect) Visit Preview May 31, 2022 at 6:27PM (UTC)

@pi0
Copy link
Member

pi0 commented Apr 19, 2022

Yarn v1 -> pnpm

pnpm is still not in a state that we can use in at least official repo and examples and advocate yet. There are issues like (unjs/nitro#106) but I guess more are still there.

Not sure how to handle SWR

It is not mandatory to me to have SWR in the initial rewrite. We are adding it to useFetch soon but you can use useAsyncData with a local implementation as well

@antfu
Copy link
Member Author

antfu commented Apr 19, 2022

Do you want to switch to Yarn v3, or?

layouts/default.vue Outdated Show resolved Hide resolved
middleware/feed.ts Outdated Show resolved Hide resolved
composables/store.ts Outdated Show resolved Hide resolved
@antfu
Copy link
Member Author

antfu commented Apr 20, 2022

Instead of merging, I think we could just switch to the default branch to nuxt3 (I already made the nuxt2 branch as a pointer). This PR serves the purpose of reviewing.

Copy link
Member

atinux commented Apr 20, 2022

I like this idea

components/ItemListNav.vue Outdated Show resolved Hide resolved
layouts/default.vue Outdated Show resolved Hide resolved
layouts/default.vue Outdated Show resolved Hide resolved
layouts/default.vue Outdated Show resolved Hide resolved
layouts/default.vue Outdated Show resolved Hide resolved
components/Item.vue Outdated Show resolved Hide resolved
pages/item/[id].vue Outdated Show resolved Hide resolved
pages/item/[id].vue Outdated Show resolved Hide resolved
@atinux
Copy link
Member

atinux commented May 17, 2022

Added a review for using NuxtLink instead of RouterLink

app.vue Outdated Show resolved Hide resolved
@atinux
Copy link
Member

atinux commented May 18, 2022

Would you mind improving the SEO?

  • description
  • Twitter card, etc

Screenshot 2022-05-18 at 14 04 25@2x

You can use this extension to see it in development: https://chrome.google.com/webstore/detail/social-share-preview/ggnikicjfklimmffbkhknndafpdlabib/related?hl=en

@antfu antfu changed the title feat: init migration to nuxt3 feat: migration to nuxt3 May 23, 2022
@atinux atinux requested a review from pi0 May 23, 2022 08:54
components/ItemListNav.vue Outdated Show resolved Hide resolved
components/ItemListNav.vue Outdated Show resolved Hide resolved
@atinux
Copy link
Member

atinux commented Aug 3, 2022

Thank you @antfu and sorry for the long time reviewing it.

So far we won't push the marketing of it until we push the PWA support into Nuxt 3 with Pooya 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants