feat: prevent endless reloading #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
Sep 21, 2019
app/app.vue
Outdated
| <div v-else-if="preventReload" class="reload_prevented"> | ||
| <h3 class="hasErrors">Failed to show Nuxt.js app after {{ maxReloadCount }} reloads</h3> | ||
| <p> | ||
| Your Nuxt.js app could not be shown after {{ maxReloadCount }} reloads |
There was a problem hiding this comment.
This is somehow repeated and not useful for user
There was a problem hiding this comment.
Have shortened the line in the paragraph, some repetition seems to be unavoidable? Or do you have a better suggestion?
| @@ -0,0 +1,25 @@ | |||
| const baseKey = '__nuxt_loading_screen_' | |||
|
|
|||
| export default { | |||
There was a problem hiding this comment.
Vue/Nuxt plugin idea: A mixin to automatically sync component state :D
pi0
approved these changes
Sep 21, 2019
Merged
This was referenced Oct 2, 2019
Closed
Closed
This was referenced Oct 14, 2019
This was referenced Nov 12, 2019
This was referenced Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When somehow the nuxt app can not be shown, the loading screen would keep endlessly reloading.
I think that in almost any case when this issue happens the user has hit a webpack issue. This feature is in no means a fix for anything, it just prevents possible developer confusion as its difficult to understand why the reloading occurs as probably almost nobody knows that the nuxt loading screen does this reloading.