Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): hide unhandled error messages in prod #28156

Merged
merged 9 commits into from
Jul 17, 2024
Merged

Conversation

danielroe
Copy link
Member

🔗 Linked issue

nitrojs/nitro#2591

📚 Description

This applies a fix made in nitro to our forked version of error utility. From @pi0:

We should hide error messages (to client) in case of unhandled errors because they can include internal server state.

Thanks for @GalacticHypernova for discovering this! (issue was if a chunk is missing, we were showing full path but it can be extended to other causes)

Note: This might be a minor behavior change but since we only hide unhandled errors, (new Error not createError) i guess should be safe for v2 as patch.

Copy link

stackblitz bot commented Jul 15, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot added the 3.x label Jul 15, 2024
test/basic.test.ts Outdated Show resolved Hide resolved
@danielroe danielroe merged commit 42ef331 into main Jul 17, 2024
38 checks passed
@danielroe danielroe deleted the fix/unhandled-errors branch July 17, 2024 11:13
@github-actions github-actions bot mentioned this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants