perf(nuxt): prevent converting client only component setup to Promise #28334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
huang-julien
changed the title
danielroe
reviewed
Aug 5, 2024
|
@danielroe so with this fix, we still need to wait exactly 3 ticks until the client component is mounted. Should we instead advise users to use |
huang-julien
changed the title
…m/nuxt/nuxt into perf/client-only-ignore-hydration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
closes #27999
📚 Description
Hey 👋
This PR improve components from
createClientComponentif they are mounted after hydration. This bypass all code run specifically for hydration. Meaning the component will directly be returned if nuxt has already been hydrated.This PR also treeshake code that is not required server side