feat: improve isNuxtError() type inference
#28814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
gianlucadifrancesco
changed the title
isNuxtError type inferenceisNuxtError() type inference
4 tasks
danielroe
approved these changes
Sep 3, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #28813
📚 Description
This PR will improve the type inference of
isNuxtError(), without changing its implementation at all.The change is a one-liner, very simple, but it offers several advantages:
unknownto improve DX and avoid casting.error is NuxtError<DataT>) will always be applied after being asserted.isNuxtError()without a param, as it's not particularly meaningful on its own.