feat(builder): extendPlugins option and builder:extendPlugins' hook
#6285
Conversation
| @@ -225,7 +225,7 @@ export default class Builder { | |||
| } | |||
|
|
|||
| // Plugins | |||
| this.plugins = Array.from(this.normalizePlugins()) | |||
| this.plugins = Array.from(await this.normalizePlugins()) | |||
There was a problem hiding this comment.
Do we have to do sth. with regards to error handling here?
There was a problem hiding this comment.
Don't think so because that would be an user-space error?
|
Besides my annotation in the code, I'd like to see a more illuminating description for the PR, e.g., why introducing the change, what benefits, maybe even potential drawbacks. For other contributors (besides the core team), the description isn't helpful as is and not transparent. |
|
@manniL agreed, I have updated the description with more info. |
Codecov Report
@@ Coverage Diff @@
## dev #6285 +/- ##
==========================================
+ Coverage 95.71% 95.72% +<.01%
==========================================
Files 79 79
Lines 2661 2666 +5
Branches 681 683 +2
==========================================
+ Hits 2547 2552 +5
Misses 98 98
Partials 16 16
Continue to review full report at Codecov.
|
galvez
changed the title
pimlie
changed the title
|
By request of @galvez I've added support for |
pi0
changed the title
extendPlugins option and builder:extendPlugins' hook
Currently there's no way to determine the final ordering of user-space plugins in relation to plugins registered automatically by modules (and not all modules necessarily use
addPlugin(), which usesunshift()). The problem is complex and likely to have other takes, but as @pi0 said:So this introduces a new
build:extendPluginsconfiguration hook, similar toextendRoutes(), that allows users to completely modify the order of all plugins before the build.