Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose hooks for extensibility #111

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Conversation

antfu
Copy link
Member

@antfu antfu commented Sep 18, 2023

For Nuxt DevTools to logs it's own events. I am not sure if there is a way to prevent arbitrary modules from hooking into it tho.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 85.71% and project coverage change: +0.51% 🎉

Comparison is base (46e9f25) 82.24% compared to head (d3d79fa) 82.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   82.24%   82.76%   +0.51%     
==========================================
  Files          19       19              
  Lines         614      615       +1     
  Branches       71       71              
==========================================
+ Hits          505      509       +4     
+ Misses        109      105       -4     
- Partials        0        1       +1     
Files Changed Coverage Δ
src/telemetry.ts 75.00% <80.00%> (+3.12%) ⬆️
src/module.ts 95.65% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielroe danielroe requested a review from atinux September 18, 2023 08:16
@atinux
Copy link
Member

atinux commented Sep 18, 2023

Good for me too, I let you merge and release @danielroe

@danielroe danielroe merged commit 0ad51d2 into nuxt:main Sep 18, 2023
@antfu antfu deleted the feat/expose-hooks branch September 18, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants