Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move cli to citty #197

Merged
merged 4 commits into from
Dec 20, 2024
Merged

refactor: move cli to citty #197

merged 4 commits into from
Dec 20, 2024

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

this aligns the telemetry cli with rest of nuxt ecosystem, also potentially reducing dependencies (mri is dropped)

it also supports more config formats (.mjs and .config dir), though we might consider using c12 in future (what do you think @pi0?)

@danielroe danielroe requested a review from pi0 December 20, 2024 10:12
@danielroe danielroe self-assigned this Dec 20, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left 2 comments otherwise nice works ❀️

also agree about migrating to c12 btw it reduces complexity with no cost

src/cli.ts Show resolved Hide resolved
src/cli.ts Outdated Show resolved Hide resolved
@danielroe danielroe merged commit 9d2c4a9 into main Dec 20, 2024
3 checks passed
@danielroe danielroe deleted the refactor/citty branch December 20, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants