Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(playwright): allow providing default test options #1001

Merged
merged 6 commits into from
Dec 3, 2024

Conversation

GaborTorma
Copy link
Contributor

@GaborTorma GaborTorma commented Nov 3, 2024

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

If we configure nuxt object in playwright.config.ts projects and later use test.use with nuxt options. The test.use nuxt options overwrite the playwright.config.ts projects config, not merging.
I intruduce a new defaults options with nuxt property, that we can use in playwright.config.ts projects to merging it with test.use nuxt options.

Example usage in my playwright.config.ts and client.test.ts files in nuxt-feathers module.

@GaborTorma GaborTorma requested a review from danielroe as a code owner November 3, 2024 10:30
@danielroe danielroe changed the title feat: support default options for nuxt config in playwright feat(playwright): support default options for nuxt config Dec 3, 2024
@danielroe danielroe changed the title feat(playwright): support default options for nuxt config feat(playwright): allow providing default test options Dec 3, 2024
@danielroe
Copy link
Member

danielroe commented Dec 3, 2024

(no need to merge unless there's a conflict - I can always do it - and it tends to delay me as I have to approve rerunning the tests again.)

@danielroe danielroe merged commit a4993df into nuxt:main Dec 3, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants