Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing method types for moduleContainer #120

Merged
merged 4 commits into from
May 10, 2021
Merged

fix: add missing method types for moduleContainer #120

merged 4 commits into from
May 10, 2021

Conversation

achimoraites
Copy link

Included the addModule option in the module testing page

fixes #312

@mrazauskas
Copy link

Would be good to fix typings as well.

@achimoraites
Copy link
Author

Thanks a lot @mrazauskas !
I will fix them as well :)

@pi0
Copy link
Member

pi0 commented May 10, 2021 •
edited
Loading

Also missing: addTemplate, extendBuild, extendRoutes, addModule (reference: https://github.com/nuxt/nuxt.js/blob/dev/packages/core/src/module.js)

@achimoraites
Copy link
Author

Thanks @pi0 !
Will include them as well!

@pi0 pi0 changed the title docs: include "addModule" option fix: add missing method types for moduleContainer May 10, 2021
@pi0 pi0 merged commit 642e1d7 into nuxt:main May 10, 2021
@achimoraites achimoraites deleted the docs/add--addModule-option branch May 10, 2021 11:21
danielroe added a commit that referenced this pull request Nov 20, 2023
@renovate @danielroe
chore(deps): update nuxt core (#120)
a51198b 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel Roe <daniel@roe.dev>
danielroe added a commit that referenced this pull request Nov 20, 2023
@renovate @danielroe
chore(deps): update nuxt core (#120)
2287db9 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel Roe <daniel@roe.dev>
danielroe added a commit that referenced this pull request Nov 21, 2023
@renovate @danielroe
chore(deps): update nuxt core (#120)
70ee964 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel Roe <daniel@roe.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

@ricardogobbosouza ricardogobbosouza ricardogobbosouza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Module testing page is missing the "addModule" option
4 participants
@achimoraites @mrazauskas @pi0 @ricardogobbosouza