Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: don't manipulate empty entries #753

Merged
merged 3 commits into from
Apr 17, 2024
Merged

perf: don't manipulate empty entries #753

merged 3 commits into from
Apr 17, 2024

Conversation

GalacticHypernova
Copy link
Contributor

This PR prevents manipulation of empty entries (arrays, strings, etc) which have no point except increasing execution time.

@GalacticHypernova GalacticHypernova marked this pull request as draft February 9, 2024 13:46
@danielroe danielroe marked this pull request as ready for review April 17, 2024 14:43
@danielroe danielroe merged commit ceebb2e into nuxt:main Apr 17, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Apr 17, 2024
Closed
@GalacticHypernova
Copy link
Contributor Author

Oops, I totally forgot about this 😅
There were a couple more things I wanted to add to this, am I able to make another PR for this?

@danielroe Volta.net
Copy link
Member

Of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GalacticHypernova @danielroe