Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): upgrade execa to v9 #843

Merged
merged 1 commit into from
May 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"defu": "^6.1.4",
"destr": "^2.0.3",
"estree-walker": "^3.0.3",
"execa": "^8.0.1",
"execa": "^9.1.0",
"fake-indexeddb": "^5.0.2",
"get-port-please": "^3.1.2",
"local-pkg": "^0.5.0",
Expand Down Expand Up @@ -151,7 +151,7 @@
"vue": "^3.4.27"
},
"engines": {
"node": "^14.18.0 || >=16.10.0"
"node": ">=18.19.0"
},
"packageManager": "pnpm@9.1.0"
}
103 changes: 101 additions & 2 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion src/core/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import type { FetchOptions } from 'ofetch'
import { $fetch as _$fetch, fetch as _fetch } from 'ofetch'
import * as _kit from '@nuxt/kit'
import { resolve } from 'pathe'

import { useTestContext } from './context'

// @ts-expect-error type cast kit default export
Expand Down Expand Up @@ -70,7 +71,7 @@ export async function startServer(options: StartServerOptions = {}) {
export async function stopServer() {
const ctx = useTestContext()
if (ctx.serverProcess) {
await ctx.serverProcess.kill()
ctx.serverProcess.kill()
}
}

Expand Down
4 changes: 2 additions & 2 deletions src/core/types.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { Nuxt, NuxtConfig } from '@nuxt/schema'
import type { ExecaChildProcess } from 'execa'
import type { Subprocess } from 'execa'
import type { Browser, LaunchOptions } from 'playwright-core'

export type TestRunner = 'vitest' | 'jest' | 'cucumber'
Expand Down Expand Up @@ -31,7 +31,7 @@ export interface TestContext {
nuxt?: Nuxt
browser?: Browser
url?: string
serverProcess?: ExecaChildProcess
serverProcess?: Subprocess
mockFn?: (...args: unknown[]) => unknown
/**
* Functions to run on the vitest `afterAll` hook.
Expand Down
Loading