feat(runtime-utils): expose setup context from renderSuspended result
#852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
joaovitoras
changed the title
|
@danielroe This PR is ready! Can you review this or assign someone? |
danielroe
changed the title
renderSuspended result
danielroe
changed the title
renderSuspended resultrenderSuspended result
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a lot of internal testing in my private project and seeing some similar opened issues about the context returned by setup was not being accessible in the component, I saw that there was a difference in the way how
mountSuspendedandrenderSuspendedwere defined.In
mountSuspendedthings always worked, looking at the difference between the two I ended up arriving at the PR danielroe/nuxt-vitest#391 which introduced a fix for this, but only on the mountSuspended functionIt would be cool at some point to unify what is possible in these two functions. There is a lot of duplicated logic between both
Fix: #722