Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): use connect type for server middleware #227

Merged
merged 1 commit into from
Dec 2, 2019

Conversation

danielroe
Copy link
Member

closes #183

(if you haven't already been working on this)

@kevinmarrec kevinmarrec added fix Pull requests that fix a bug types The issue or pull request is related to `types` package labels Dec 2, 2019
Copy link
Contributor

@kevinmarrec kevinmarrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@kevinmarrec kevinmarrec merged commit 0d50ef2 into nuxt:master Dec 2, 2019
@trygveaa
Copy link
Contributor

trygveaa commented Dec 2, 2019

You should probably remove @types/express from package.json too? It's not used anywhere anymore.

@kevinmarrec
Copy link
Contributor

@trygveaa You're right, it is also a dependency of @types/compression : https://github.com/nuxt/typescript/blob/master/yarn.lock#L2176 so it can be safely removed from package.json

@trygveaa
Copy link
Contributor

trygveaa commented Dec 2, 2019

@kevinmarrec: Why does it matter if it's a dependency of @types/compression when it isn't used?

@kevinmarrec
Copy link
Contributor

kevinmarrec commented Dec 2, 2019

@trygveaa I meant even if it was used it could have been omitted from package.json as @types/compression would install it anyways :)

I've local changes ready but there's an issue regarding a package (zloirock/core-js#711) which is buggy until NPM registry is correctly updated, so i'm just waiting a bit to have the lock file maintnance as well to have yarn.lock clean after removal.

EDIT : Done 31108af

@danielroe danielroe deleted the server-middleware-type branch December 2, 2019 19:54
@kevinmarrec
Copy link
Contributor

kevinmarrec commented Dec 2, 2019

Done 31108af

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull requests that fix a bug types The issue or pull request is related to `types` package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong type for ServerMiddleware
3 participants