Skip to content

Commit

Permalink
fix(Select): consistent placeholder with input and textarea
Browse files Browse the repository at this point in the history
Resolves #1276
  • Loading branch information
benjamincanac committed Jan 24, 2024
1 parent 6fafd78 commit 2cb41db
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/runtime/components/forms/Select.vue
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ export default defineComponent({
variant?.replaceAll('{color}', color.value),
(isLeading.value || slots.leading) && ui.value.leading.padding[size.value],
(isTrailing.value || slots.trailing) && ui.value.trailing.padding[size.value]
), props.selectClass)
), props.placeholder && !props.modelValue && ui.value.placeholder, props.selectClass)
})
const isLeading = computed(() => {
Expand Down
2 changes: 1 addition & 1 deletion src/runtime/components/forms/SelectMenu.vue
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ export default defineComponent({
variant?.replaceAll('{color}', color.value),
(isLeading.value || slots.leading) && ui.value.leading.padding[size.value],
(isTrailing.value || slots.trailing) && ui.value.trailing.padding[size.value]
), props.selectClass)
), props.placeholder && !props.modelValue && ui.value.placeholder, props.selectClass)
})
const isLeading = computed(() => {
Expand Down
2 changes: 1 addition & 1 deletion src/runtime/ui.config/forms/select.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import input from './input'
export default {
...input,
form: 'form-select',
placeholder: 'text-gray-900 dark:text-white',
placeholder: 'text-gray-400 dark:text-gray-500',
default: {
size: 'sm',
color: 'white',
Expand Down

1 comment on commit 2cb41db

@vercel
Copy link

@vercel vercel bot commented on 2cb41db Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

ui – ./

ui-git-dev-nuxt-js.vercel.app
ui-nuxt-js.vercel.app
ui.nuxt.com

Please sign in to comment.