Skip to content

Commit

Permalink
fix(forms): dont disable inputs and selects on loading
Browse files Browse the repository at this point in the history
Resolves #1117
  • Loading branch information
benjamincanac committed Jan 5, 2024
1 parent 520624b commit 3258167
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/runtime/components/forms/Input.vue
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
:type="type"
:required="required"
:placeholder="placeholder"
:disabled="disabled || loading"
:disabled="disabled"
:class="inputClass"
v-bind="attrs"
@input="onInput"
Expand Down
4 changes: 2 additions & 2 deletions src/runtime/components/forms/InputMenu.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
:by="by"
:name="name"
:model-value="modelValue"
:disabled="disabled || loading"
:disabled="disabled"
as="div"
:class="ui.wrapper"
@update:model-value="onUpdate"
Expand All @@ -15,7 +15,7 @@
:name="name"
:required="required"
:placeholder="placeholder"
:disabled="disabled || loading"
:disabled="disabled"
:class="inputClass"
autocomplete="off"
v-bind="attrs"
Expand Down
2 changes: 1 addition & 1 deletion src/runtime/components/forms/Select.vue
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
:name="name"
:value="modelValue"
:required="required"
:disabled="disabled || loading"
:disabled="disabled"
:class="selectClass"
v-bind="attrs"
@input="onInput"
Expand Down
4 changes: 2 additions & 2 deletions src/runtime/components/forms/SelectMenu.vue
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
:name="name"
:model-value="modelValue"
:multiple="multiple"
:disabled="disabled || loading"
:disabled="disabled"
as="div"
:class="ui.wrapper"
@update:model-value="onUpdate"
Expand All @@ -28,7 +28,7 @@
:class="uiMenu.trigger"
>
<slot :open="open" :disabled="disabled" :loading="loading">
<button :id="inputId" :class="selectClass" :disabled="disabled || loading" type="button" v-bind="attrs">
<button :id="inputId" :class="selectClass" :disabled="disabled" type="button" v-bind="attrs">
<span v-if="(isLeading && leadingIconName) || $slots.leading" :class="leadingWrapperIconClass">
<slot name="leading" :disabled="disabled" :loading="loading">
<UIcon :name="leadingIconName" :class="leadingIconClass" />
Expand Down

0 comments on commit 3258167

Please sign in to comment.