fix(RadioGroup): props reactivity issues (#1065)

nuxt · Dec 6, 2023 · 7196d81 · 7196d81 · vercel · Dec 6, 2023
1 parent 1cb8df8
commit 7196d81
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/runtime/components/forms/RadioGroup.vue b/src/runtime/components/forms/RadioGroup.vue
@@ -99,7 +99,7 @@ export default defineComponent({
     const { ui, attrs } = useUI('radioGroup', toRef(props, 'ui'), config, toRef(props, 'class'))
     const { ui: uiRadio } = useUI('radio', toRef(props, 'uiRadio'), configRadio)
 
-    const { emitFormChange, color, name } = useFormGroup({ ...props, isFieldset: true }, config)
+    const { emitFormChange, color, name } = useFormGroup(props, config)
     provide('radio-group', { color, name })
 
     const onUpdate = (value: any) => {

diff --git a/src/runtime/composables/useFormGroup.ts b/src/runtime/composables/useFormGroup.ts
@@ -8,8 +8,8 @@ type InputProps = {
   size?: string | number | symbol
   color?: string
   name?: string
-  isFieldset?: boolean
   eagerValidation?: boolean
+  legend?: string | null
 }
 
 export const useFormGroup = (inputProps?: InputProps, config?: any) => {
@@ -20,7 +20,8 @@ export const useFormGroup = (inputProps?: InputProps, config?: any) => {
     const inputId = ref(inputProps?.id)
 
     onMounted(() => {
-      inputId.value = inputProps?.isFieldset ? undefined : inputProps?.id ?? uid()
+      // Remove FormGroup label bindings for RadioGroup elements to avoid label conflicts
+      inputId.value = inputProps?.legend === null || inputProps.legend ? undefined : inputProps?.id ?? uid()
 
       if (formGroup) {
         // Updates for="..." attribute on label if inputProps.id is provided