-
Notifications
You must be signed in to change notification settings - Fork 462
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(ButtonGroup): handle components with children (#999)
Co-authored-by: Benjamin Canac <canacb1@gmail.com>
- Loading branch information
1 parent
c9b9bd6
commit f4be95d
Showing
7 changed files
with
130 additions
and
53 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| import { computed, ref, provide, inject, onMounted, onUnmounted, getCurrentInstance } from 'vue' | ||
| import type { Ref, ComponentInternalInstance } from 'vue' | ||
| import { buttonGroup } from '#ui/ui.config' | ||
|
|
||
| type ButtonGroupProps = { | ||
| orientation?: Ref<'horizontal' | 'vertical'> | ||
| size?: Ref<string> | ||
| ui?: Ref<Partial<typeof buttonGroup>> | ||
| rounded?: Ref<{ start: string, end: string }> | ||
| } | ||
|
|
||
| // make a ButtonGroupContext type for injection. Should include ButtonGroupProps | ||
| type ButtonGroupContext = { | ||
| children: ComponentInternalInstance[] | ||
| register(child: ComponentInternalInstance): void | ||
| unregister(child: ComponentInternalInstance): void | ||
| orientation: 'horizontal' | 'vertical' | ||
| size: string | ||
| ui: Partial<typeof buttonGroup> | ||
| rounded: { start: string, end: string } | ||
| } | ||
|
|
||
| export function useProvideButtonGroup (buttonGroupProps: ButtonGroupProps) { | ||
| const instance = getCurrentInstance() | ||
| const groupKey = `group-${instance.uid}` | ||
| const state = ref({ | ||
| children: [], | ||
| register (child) { | ||
| this.children.push(child) | ||
| }, | ||
| unregister (child) { | ||
| const index = this.children.indexOf(child) | ||
| if (index > -1) { | ||
| this.children.splice(index, 1) | ||
| } | ||
| }, | ||
| ...buttonGroupProps | ||
| }) | ||
| provide(groupKey, state as Ref<ButtonGroupContext>) | ||
| } | ||
|
|
||
| export function useInjectButtonGroup ({ ui, props }: { ui: any, props: any }) { | ||
| const instance = getCurrentInstance() | ||
|
|
||
| let parent = instance.parent | ||
| let groupContext: Ref<ButtonGroupContext> | undefined | ||
|
|
||
| // Traverse up the parent chain to find the nearest ButtonGroup | ||
| while (parent && !groupContext) { | ||
| if (parent.type.name === 'ButtonGroup') { | ||
| groupContext = inject(`group-${parent.uid}`) | ||
| break | ||
| } | ||
| parent = parent.parent | ||
| } | ||
|
|
||
| const positionInGroup = computed(() => groupContext?.value.children.indexOf(instance)) | ||
| onMounted(() => { | ||
| groupContext?.value.register(instance) | ||
| }) | ||
| onUnmounted(() => { | ||
| groupContext?.value.unregister(instance) | ||
| }) | ||
| return { | ||
| size: computed(() => groupContext?.value.size || props.size), | ||
| rounded: computed(() => { | ||
| if (!groupContext || positionInGroup.value === -1) return ui.value.rounded | ||
| if (groupContext.value.children.length === 1) return groupContext.value.ui.rounded | ||
| if (positionInGroup.value === 0) return groupContext.value.rounded.start | ||
| if (positionInGroup.value === groupContext.value.children.length - 1) return groupContext.value.rounded.end | ||
| return 'rounded-none' | ||
| }) | ||
| } | ||
| } |
f4be95dThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs:
ui – ./
ui.nuxt.com
ui-git-dev-nuxt-js.vercel.app
ui-nuxt-js.vercel.app