-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ButtonGroup): handle components with children #999
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea on the preview why the size
and orientation
props are not reactive? It does the same when using the component.
https://ui-6r8tp8i74-nuxt-js.vercel.app/dev/elements/button#group
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me π
Amazing work really, you saved me on this! Thanks a lot β€οΈ
No problem at all! Thanks for the advice on the other PR and pointing me in the direction of Anthony's solution. Really made me rethink the problem and I got to learn from it all π |
π Linked issue
#256
β Type of change
π Description
Trying another shot at this one π Using provide/inject through the new
useButtonGroup
composable. Using Vue'sgetCurrentInstance
so that a child can figure out it's position in theButtonGroup
and adjust it's roundness accordingly.Added this functionality to the
Badge
,Button
,Input
,Select
, andSelectMenu
componentsResolves #256
π Checklist