Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CommandPalette): improve accessibility #129

Merged
merged 2 commits into from
Feb 3, 2023

Conversation

kevinmarrec
Copy link
Contributor

Should fix any accessibility issues regarding CommandPalette on https://nuxt.studio (nested ul + li with various aria issues) :

image
image
image
image

These issues are all fixed with these changes (tested locally)

@vercel
Copy link

vercel bot commented Feb 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ui ✅ Ready (Inspect) Visit Preview Feb 3, 2023 at 3:01PM (UTC)

@netlify
Copy link

netlify bot commented Feb 3, 2023

Deploy Preview for nuxthq-ui canceled.

Name Link
🔨 Latest commit b8c36f5
🔍 Latest deploy log https://app.netlify.com/sites/nuxthq-ui/deploys/63dd2187cf7e9900094be511

@benjamincanac benjamincanac merged commit bea47b5 into dev Feb 3, 2023
@benjamincanac benjamincanac deleted the command-palette-accessibility branch February 3, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants