Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Avatar): Enhance type of Avatar component's props #1901

Closed
wants to merge 1 commit into from

Conversation

hckhanh
Copy link

@hckhanh hckhanh commented Jun 22, 2024

I think that the type of src, alt and text should be enhanced to make it more friendly with TypeScript

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

I think that the type of `src`, `alt` and `text` should be enhanced to make it more friendly with TypeScript
@hckhanh hckhanh changed the title feat(types): Enhance type of Avatar component's props feat(Avatar): Enhance type of Avatar component's props Jun 22, 2024
@benjamincanac
Copy link
Member

I don't think this is necessary, the prop types should already be inferred automatically: https://vuejs.org/guide/typescript/overview.html#definecomponent

@hckhanh
Copy link
Author

hckhanh commented Aug 8, 2024

@benjamincanac Did you get any warnings about this in VSCode or WebStorm? I got a warning about the type mismatch in WebStorm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants