Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(unplugin): invalid url schema on windows #2899

Merged
merged 1 commit into from
Dec 16, 2024
Merged

fix(unplugin): invalid url schema on windows #2899

merged 1 commit into from
Dec 16, 2024

Conversation

ivanmaxlogiudice
Copy link
Contributor

@ivanmaxlogiudice ivanmaxlogiudice commented Dec 13, 2024 •
edited by benjamincanac
Loading

🔗 Linked issue

Resolves #2831, resolves #2518

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 13, 2024 

npm i https://pkg.pr.new/@nuxt/ui@2899

commit: 416f962

@benjamincanac
Copy link
Member

Does this solve #2518? 🤔

@ivanmaxlogiudice
Copy link
Contributor Author

Does this solve #2518? 🤔

i followed his reproduction steps and it works fine

image

i will ask if it works with this PR.

@ivanmaxlogiudice ivanmaxlogiudice mentioned this pull request Dec 16, 2024
Closed
@benjamincanac benjamincanac added the v3 #1289 label Dec 16, 2024
@benjamincanac benjamincanac merged commit 9b4694f into nuxt:v3 Dec 16, 2024
2 checks passed
@benjamincanac
Copy link
Member

Thanks @ivanmaxlogiudice! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

@danielroe danielroe Awaiting requested review from danielroe

Assignees
No one assigned
Labels
v3 #1289
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build of the vue version Adding the plugin to a Vite project with AdonisJS and Inertia cause an error
2 participants
@ivanmaxlogiudice @benjamincanac