feat: dedupe meta objects by VMID #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should yes |
Codecov Report
@@ Coverage Diff @@
## master #282 +/- ##
=========================================
+ Coverage 40.15% 40.6% +0.44%
=========================================
Files 18 18
Lines 264 266 +2
=========================================
+ Hits 106 108 +2
Misses 158 158
Continue to review full report at Codecov.
|
manniL
changed the title
manniL
commented
Dec 18, 2018
| @@ -64,6 +66,10 @@ export default function getComponentOption (opts, result = {}) { | |||
|
|
|||
| return metaObject | |||
| }) | |||
| result.meta = uniqBy( | |||
| result.meta.reverse(), | |||
There was a problem hiding this comment.
I had to reverse the list to always consider the last meta object as the "true" one
manniL
commented
Dec 18, 2018
| @@ -64,6 +66,10 @@ export default function getComponentOption (opts, result = {}) { | |||
|
|
|||
| return metaObject | |||
| }) | |||
| result.meta = uniqBy( | |||
| result.meta.reverse(), | |||
| metaObject => metaObject.hasOwnProperty(tagIDKeyName) ? metaObject[tagIDKeyName] : uniqueId() | |||
There was a problem hiding this comment.
I had to implement a workaround for tags without vmid set at all (which is common if you want to multiple tags of the same type)
My first idea was to use Symbol but it is not supported in IE :(
So I had to use another lodash fn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: nuxt/nuxt#4282
Whether or not that feature should be supported by vue-meta is another thing to discuss.