Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: export types for meta, link, script interfaces #441

Merged
merged 1 commit into from
Aug 30, 2019

Conversation

rchl
Copy link
Contributor

@rchl rchl commented Aug 28, 2019

To be able to annotate those in user's code when stored individually.

Resolves #440

@codecov
Copy link

codecov bot commented Aug 28, 2019

Codecov Report

Merging #441 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #441   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          34     34           
  Lines         547    547           
  Branches      153    153           
=====================================
  Hits          547    547

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96a14f7...12e4c1e. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Aug 28, 2019

Codecov Report

Merging #441 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #441   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          34     34           
  Lines         547    547           
  Branches      153    153           
=====================================
  Hits          547    547

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96a14f7...12e4c1e. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 28, 2019

Codecov Report

Merging #441 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #441   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          34     34           
  Lines         547    547           
  Branches      153    153           
=====================================
  Hits          547    547

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96a14f7...12e4c1e. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 28, 2019

Codecov Report

Merging #441 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #441   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          34     34           
  Lines         547    547           
  Branches      153    153           
=====================================
  Hits          547    547

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96a14f7...53c6202. Read the comment docs.

Copy link
Collaborator

@pimlie pimlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think the attributes are missing or did you leave those out on purpose?

To be able to annotate those in user's code when stored individually.

Resolves nuxt#440
@rchl
Copy link
Contributor Author

rchl commented Aug 29, 2019

AttributeProperty, you mean? I've missed it. Now added.

@pimlie pimlie merged commit dc30544 into nuxt:master Aug 30, 2019
@rchl rchl deleted the fix/export-more-types branch August 30, 2019 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[types] Individiual meta object types not exported
2 participants