Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: try to detect global mixins adding meta info #467

Merged
merged 3 commits into from
Oct 9, 2019

Conversation

pimlie
Copy link
Collaborator

@pimlie pimlie commented Oct 8, 2019

fix: make sure that beforeMount hook to hydrate from ssr is only added once (disclaimer, havent been able to trigger an issue with this manually tough)

Recently there have been some issues due to third party libs adding a global mixin which sets meta information. Since v2.3 that is not the recommended approach anymore (using addApp is). This pr tries to detect if a global mixin adding keyName was used and logs a warning about that

@codecov
Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #467 into master will decrease coverage by 0.73%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #467      +/-   ##
=========================================
- Coverage   99.84%   99.1%   -0.74%     
=========================================
  Files          33      33              
  Lines         659     674      +15     
  Branches      198     204       +6     
=========================================
+ Hits          658     668      +10     
- Misses          1       4       +3     
- Partials        0       2       +2
Impacted Files Coverage Δ
src/shared/mixin.js 93.33% <71.42%> (-5.16%) ⬇️
src/utils/array.js 95.45% <83.33%> (-4.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7404953...715e0c7. Read the comment docs.

@pimlie pimlie merged commit 2231ec1 into master Oct 9, 2019
@pimlie pimlie deleted the feat-detect-global-meta-mixin branch July 26, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant