Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for global inject options #568

Merged
merged 2 commits into from
Jun 7, 2020

Conversation

pimlie
Copy link
Collaborator

@pimlie pimlie commented May 30, 2020

See the added docs.

This pr doesnt fix anything, just provides a (possible) cleaner API to integrators.

@pimlie pimlie requested a review from pi0 May 30, 2020 13:27
@codecov
Copy link

codecov bot commented May 30, 2020

Codecov Report

Merging #568 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #568   +/-   ##
=======================================
  Coverage   98.68%   98.68%           
=======================================
  Files          33       33           
  Lines         684      687    +3     
  Branches      211      212    +1     
=======================================
+ Hits          675      678    +3     
  Misses          5        5           
  Partials        4        4           
Impacted Files Coverage Δ
src/server/generateServerInjector.js 100.00% <100.00%> (ø)
src/server/generators/attribute.js 100.00% <100.00%> (ø)
src/server/generators/tag.js 100.00% <100.00%> (ø)
src/server/inject.js 100.00% <100.00%> (ø)
src/shared/$meta.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92350d5...2b6d240. Read the comment docs.

@pimlie pimlie merged commit 8b02eb2 into master Jun 7, 2020
@pimlie pimlie deleted the feat-global-inject-options branch June 7, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant