Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRC Rename #221

Merged
211 commits merged into from
Nov 29, 2022
Merged

MRC Rename #221

211 commits merged into from
Nov 29, 2022

Conversation

ryanolson
Copy link
Contributor

@ryanolson ryanolson commented Nov 24, 2022

Closes #222

@ryanolson ryanolson requested review from a team as code owners November 24, 2022 22:31
@ryanolson ryanolson added breaking Breaking change feature request New feature or request priority 0 labels Nov 25, 2022
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have looked over this PR, and made adjustments where necessary. Looks good now

@mdemoret-nv mdemoret-nv added this to the 23.01 Refactor milestone Nov 29, 2022
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Base: 28.37% // Head: 28.35% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (d40ede9) compared to base (9fbd4a5).
Patch coverage: 2.85% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-23.01     #221      +/-   ##
================================================
- Coverage         28.37%   28.35%   -0.03%     
================================================
  Files               363      364       +1     
  Lines             10121    10129       +8     
  Branches           4783     4786       +3     
================================================
  Hits               2872     2872              
- Misses             4969     4977       +8     
  Partials           2280     2280              
Impacted Files Coverage Δ
include/mrc/benchmarking/segment_watcher.hpp 52.63% <ø> (ø)
include/mrc/benchmarking/trace_statistics.hpp 100.00% <ø> (ø)
include/mrc/benchmarking/tracer.hpp 78.00% <ø> (ø)
include/mrc/channel/buffered_channel.hpp 53.57% <ø> (ø)
include/mrc/channel/channel.hpp 81.48% <ø> (ø)
include/mrc/channel/egress.hpp 100.00% <ø> (ø)
include/mrc/channel/ingress.hpp 100.00% <ø> (ø)
include/mrc/channel/null_channel.hpp 39.13% <ø> (ø)
include/mrc/channel/recent_channel.hpp 29.78% <ø> (ø)
include/mrc/codable/api.hpp 0.00% <ø> (ø)
... and 205 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mdemoret-nv
Copy link
Contributor

@gpucibot merge

@ghost ghost merged commit edf8362 into nv-morpheus:branch-23.01 Nov 29, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change feature request New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEA]: SRF Rename to MRC
2 participants