Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++20 version of upcoming C++23 std::expected #239

Merged
2 commits merged into from
Dec 7, 2022
Merged

C++20 version of upcoming C++23 std::expected #239

2 commits merged into from
Dec 7, 2022

Conversation

ryanolson
Copy link
Contributor

@ryanolson ryanolson added improvement Improvement to existing functionality non-breaking Non-breaking change DO NOT MERGE labels Dec 2, 2022
@ryanolson ryanolson added this to the 23.01 Refactor milestone Dec 2, 2022
@ryanolson ryanolson self-assigned this Dec 2, 2022
@ryanolson ryanolson mentioned this pull request Dec 5, 2022
Merged
@ryanolson ryanolson mentioned this pull request Dec 5, 2022
Closed
2 tasks
@ryanolson ryanolson added blocker Blocks another issue/PR and removed DO NOT MERGE labels Dec 5, 2022
@ryanolson ryanolson marked this pull request as ready for review December 6, 2022 00:32
@ryanolson ryanolson requested review from a team as code owners December 6, 2022 00:32
mdemoret-nv
mdemoret-nv approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of questions

cpp/mrc/include/mrc/core/std23_expected.hpp Show resolved Hide resolved
cpp/mrc/src/internal/expected.hpp Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Base: 0.17% // Head: 0.17% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (b46aa81) compared to base (377ea65).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@               Coverage Diff               @@
##           branch-23.01    #239      +/-   ##
===============================================
- Coverage          0.17%   0.17%   -0.01%     
===============================================
  Files               401     402       +1     
  Lines             14860   14968     +108     
  Branches           8136    8136              
===============================================
  Hits                 26      26              
- Misses            14834   14942     +108
Impacted Files Coverage Δ
cpp/mrc/include/mrc/core/std23_expected.hpp 0.00% <0.00%> (ø)
cpp/mrc/src/internal/control_plane/server.cpp 0.00% <0.00%> (ø)
cpp/mrc/src/internal/expected.hpp 0.00% <ø> (ø)
cpp/mrc/src/tests/test_expected.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ryanolson
Copy link
Contributor Author

@gpucibot merge

@ghost ghost merged commit c40154c into nv-morpheus:branch-23.01 Dec 7, 2022
ghost pushed a commit that referenced this pull request Dec 9, 2022
@ryanolson
C++20 Coroutines (#244)
3c15683 
Implementation based on the work of jbaldwin/libcoro.

The reason for the fork is due to the fact that we will need to touch every awaitable object to apply a MRC context. The other major difference is ThreadPool/Scheduler/Executor discovery and a new SchedulingPolicy that will enable us to replicate boost::fiber behaviors in some critical places where coroutines will eventually replace fibers.

Blocked by #239

Authors:
  - Ryan Olson (https://github.com/ryanolson)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #244
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@ryanolson ryanolson

Labels
blocker Blocks another issue/PR improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
No open projects
MRC Boards
Status: Done
Milestone
23.01 Refactor
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanolson @mdemoret-nv