Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazy instantiation of the nvml singleton #243

Merged
1 commit merged into from
Dec 5, 2022

Conversation

ryanolson
Copy link
Contributor

No description provided.

@ryanolson ryanolson added improvement Improvement to existing functionality non-breaking Non-breaking change labels Dec 4, 2022
@ryanolson ryanolson added this to the 23.01 Refactor milestone Dec 4, 2022
@ryanolson ryanolson requested a review from a team as a code owner December 4, 2022 05:35
@ryanolson ryanolson self-assigned this Dec 4, 2022
@codecov
Copy link

codecov bot commented Dec 4, 2022

Codecov Report

Merging #243 (e6cb39f) into branch-23.01 (6f7b4ad) will increase coverage by 0.03%.
The diff coverage is 80.00%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-23.01     #243      +/-   ##
================================================
+ Coverage         46.00%   46.03%   +0.03%     
================================================
  Files               335      335              
  Lines              9278     9280       +2     
  Branches            774      773       -1     
================================================
+ Hits               4268     4272       +4     
+ Misses             5010     5008       -2     
Flag Coverage Δ
cpp 37.65% <80.00%> (+0.02%) ⬆️
py 39.28% <80.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cpp/mrc/src/internal/system/device_info.cpp 52.94% <80.00%> (+3.96%) ⬆️
cpp/mrc/src/internal/system/fiber_task_queue.cpp 65.00% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f7b4ad...e6cb39f. Read the comment docs.

Copy link
Contributor

@drobison00 drobison00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdemoret-nv mdemoret-nv removed this from the 23.01 Refactor milestone Dec 5, 2022
@mdemoret-nv
Copy link
Contributor

@gpucibot merge

@ghost ghost merged commit 9da384b into nv-morpheus:branch-23.01 Dec 5, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants