Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove draconian regex filter that eliminates entire tests from being run #246

Merged
17 commits merged into from
Dec 9, 2022

Conversation

ryanolson
Copy link
Contributor

@ryanolson ryanolson commented Dec 5, 2022

Resolves #238

TODOs:

  • add a new macro to detect if running in CI
  • enable the skipping of some tests that don't work in the CI env

@ryanolson ryanolson added improvement Improvement to existing functionality non-breaking Non-breaking change labels Dec 5, 2022
@ryanolson ryanolson self-assigned this Dec 5, 2022
@ryanolson ryanolson marked this pull request as ready for review December 8, 2022 22:00
@ryanolson ryanolson requested review from a team as code owners December 8, 2022 22:00
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions. You also are need some changes in cmake/setup_coverage.cmake

cpp/mrc/tests/test_mrc.hpp Outdated Show resolved Hide resolved
ci/scripts/github/test_codecov.sh Outdated Show resolved Hide resolved
cpp/mrc/src/tests/common.hpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #246 (bed4604) into branch-23.01 (c4f1c0d) will increase coverage by 26.05%.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           branch-23.01     #246       +/-   ##
=================================================
+ Coverage         45.63%   71.68%   +26.05%     
=================================================
  Files               327      363       +36     
  Lines              9375    11596     +2221     
  Branches            783      868       +85     
=================================================
+ Hits               4278     8313     +4035     
+ Misses             5097     3283     -1814     
Flag Coverage Δ
cpp 68.31% <66.66%> (+30.94%) ⬆️
py 38.93% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cpp/mrc/src/internal/control_plane/server.cpp 40.06% <0.00%> (+40.06%) ⬆️
cpp/mrc/src/tests/test_expected.cpp 85.41% <ø> (ø)
cpp/mrc/src/tests/test_ucx.cpp 48.64% <100.00%> (ø)
cpp/mrc/include/mrc/core/fiber_pool.hpp 100.00% <0.00%> (ø)
...pp/mrc/include/mrc/runnable/detail/type_traits.hpp 0.00% <0.00%> (ø)
cpp/mrc/src/tests/test_memory.cpp 100.00% <0.00%> (ø)
cpp/mrc/src/tests/test_ranges.cpp 100.00% <0.00%> (ø)
cpp/mrc/src/tests/test_reusable_pool.cpp 100.00% <0.00%> (ø)
cpp/mrc/src/tests/test_topology.cpp 98.43% <0.00%> (ø)
cpp/mrc/src/tests/common.cpp 100.00% <0.00%> (ø)
... and 160 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4f1c0d...bed4604. Read the comment docs.

@ryanolson ryanolson requested a review from mdemoret-nv December 9, 2022 00:23
@mdemoret-nv
Copy link
Contributor

@gpucibot merge

@ghost ghost merged commit 83f6499 into nv-morpheus:branch-23.01 Dec 9, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEA]: Enable test_mrc_private.x
2 participants