Update Task destructor logic to conform to the standard #258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using gcc, the
if(m_coroutine != nullptr)
could trigger a compilation failure if the coroutine was returning astd23::expected
with an error message of:Possibly relating to: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99599
Another workaround was to use
but since
std::coroutine_handle
provides anoperator bool()
, this is definitely the better way to go as seen by the cppreference.com examples.