-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add handling for empty downstream sources #279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like now is the time to enforce a null channel or a null cap.
Nodes with dangling outputs should throw an error and not start.
Nodes with dangling output can be null terminated which is the equivalent to dropping the data.
If the Morpheus stages, if you want this behavior by default you can opinionated it there.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.01 #279 +/- ##
================================================
+ Coverage 72.92% 72.97% +0.05%
================================================
Files 381 381
Lines 13103 13117 +14
Branches 991 991
================================================
+ Hits 9555 9572 +17
+ Misses 3548 3545 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
Previously, we supported
source->node->[nothing]
where a source object didnt have any downstream sinks to write to. In that situation, the object was just discarded on writing. This fixes the edge functionality to replicate the previous system.