Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nullptr dereference in NvmlState #319

Merged
merged 11 commits into from
Apr 14, 2023

Conversation

cwharris
Copy link
Contributor

@cwharris cwharris commented Apr 14, 2023

Fixes a bug where NvmlState was dereferencing a nullptr when libnvidia-ml.so.1 is not available.

@cwharris cwharris added bug Something isn't working non-breaking Non-breaking change labels Apr 14, 2023
@cwharris cwharris requested review from a team as code owners April 14, 2023 13:34
@cwharris cwharris requested a review from a team as a code owner April 14, 2023 17:10
@cwharris cwharris changed the title Skip tests during conda build packaging Fix nullptr dereference in NvmlState Apr 14, 2023
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Merging #319 (786ce10) into branch-23.07 (810a7a6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           branch-23.07     #319   +/-   ##
=============================================
  Coverage         73.21%   73.22%           
=============================================
  Files               390      390           
  Lines             13379    13380    +1     
  Branches           1008     1010    +2     
=============================================
+ Hits               9796     9797    +1     
  Misses             3583     3583           
Flag Coverage Δ
cpp 69.04% <100.00%> (-0.01%) ⬇️
py 42.23% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cpp/mrc/src/internal/system/device_info.cpp 56.09% <100.00%> (+0.54%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 810a7a6...786ce10. Read the comment docs.

@cwharris
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit b207fd6 into nv-morpheus:branch-23.07 Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants