-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for gc being invoked in a thread finalizer #365
Add test for gc being invoked in a thread finalizer #365
Conversation
…v-morpheus#362" This reverts commit 11c93a6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets simplify this to just use the C++ destructor which tries to grab the GIL. Remove all GC stuff since thats not related
…o call gc.collect
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.11 #365 +/- ##
================================================
+ Coverage 73.60% 73.62% +0.02%
================================================
Files 385 385
Lines 13614 13614
Branches 1029 1028 -1
================================================
+ Hits 10020 10023 +3
+ Misses 3594 3591 -3
Flags with carried forward coverage won't be shown. Click here to find out more. see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
/merge |
Description
Note:
fixes #362
Checklist