Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Quick Start Guide not use make_node_full #376

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

cwharris
Copy link
Contributor

@cwharris cwharris commented Sep 4, 2023

Replace usage of deprecated make_node_full with make_node in the Quick Start Guide. Also fix a typo.

Contributes to nv-morpheus/Morpheus#782.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@cwharris cwharris added doc Improvements or additions to documentation non-breaking Non-breaking change labels Sep 4, 2023
@cwharris cwharris requested a review from a team as a code owner September 4, 2023 23:08
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #376 (a17de87) into branch-23.11 (a2a9829) will increase coverage by 21.90%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           branch-23.11     #376       +/-   ##
=================================================
+ Coverage         51.20%   73.11%   +21.90%     
=================================================
  Files               346      382       +36     
  Lines             11041    13403     +2362     
  Branches            930     1010       +80     
=================================================
+ Hits               5654     9799     +4145     
+ Misses             5387     3604     -1783     
Flag Coverage Δ
cpp 69.04% <ø> (+26.07%) ⬆️
py 42.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 162 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2a9829...a17de87. Read the comment docs.

@cwharris
Copy link
Contributor Author

cwharris commented Sep 7, 2023

/merge

@rapids-bot rapids-bot bot merged commit 483194d into nv-morpheus:branch-23.11 Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants