-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert boost upgrade, and update clang to v16 #382
Revert boost upgrade, and update clang to v16 #382
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-23.11 #382 +/- ##
================================================
- Coverage 73.11% 73.11% -0.01%
================================================
Files 382 382
Lines 13403 13403
Branches 1010 1010
================================================
- Hits 9800 9799 -1
- Misses 3603 3604 +1
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: What was the reason for upgrading boost and libhwloc? Do we need to re-evaluate those conditions now?
Boost was upgraded in #364, but I do not see a reason given. Looking through other sources, my understanding is that upgrading boost fixed something related to clang's build. By upgrading clang instead, it sounds like we are bypassing that problem with clang, which gives us the opportunity to use the older version of boost. We should consider whether upgrading boost in the future is going to be problem, and, more importantly, why it was an issue this time. |
The reason was a newer build of clang-15 was uploaded to conda-forge, which broke CI, not just CI actually cmake failed early on compiler check. It wasn't a point release which made it difficult to avoid. The solution then, was to upgrade boost, however that brought about breaking changes in the way promises in boost:fibers are handled. This pr takes us back to our prior version of boost, and we avoid the bad build of clang-15 by adopting clang-16. |
/merge |
This reverts commit 5747320.
Description
fixes #379 ?
Checklist