Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert boost upgrade, and update clang to v16 #382

Merged

Conversation

dagardner-nv
Copy link
Contributor

Description

fixes #379 ?

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested a review from a team as a code owner September 8, 2023 19:50
@dagardner-nv dagardner-nv added bug Something isn't working non-breaking Non-breaking change DO NOT MERGE 3 - Ready for Review and removed DO NOT MERGE labels Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #382 (3999f28) into branch-23.11 (483194d) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-23.11     #382      +/-   ##
================================================
- Coverage         73.11%   73.11%   -0.01%     
================================================
  Files               382      382              
  Lines             13403    13403              
  Branches           1010     1010              
================================================
- Hits               9800     9799       -1     
- Misses             3603     3604       +1     
Flag Coverage Δ
cpp 69.04% <ø> (-0.01%) ⬇️
py 42.05% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 483194d...3999f28. Read the comment docs.

Copy link
Contributor

@cwharris cwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: What was the reason for upgrading boost and libhwloc? Do we need to re-evaluate those conditions now?

ci/conda/environments/clang_env.yml Show resolved Hide resolved
@cwharris
Copy link
Contributor

cwharris commented Sep 8, 2023

Boost was upgraded in #364, but I do not see a reason given. Looking through other sources, my understanding is that upgrading boost fixed something related to clang's build. By upgrading clang instead, it sounds like we are bypassing that problem with clang, which gives us the opportunity to use the older version of boost.

We should consider whether upgrading boost in the future is going to be problem, and, more importantly, why it was an issue this time.

@dagardner-nv
Copy link
Contributor Author

Boost was upgraded in #364, but I do not see a reason given.

The reason was a newer build of clang-15 was uploaded to conda-forge, which broke CI, not just CI actually cmake failed early on compiler check. It wasn't a point release which made it difficult to avoid. The solution then, was to upgrade boost, however that brought about breaking changes in the way promises in boost:fibers are handled.

This pr takes us back to our prior version of boost, and we avoid the bad build of clang-15 by adopting clang-16.

@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 5747320 into nv-morpheus:branch-23.11 Sep 11, 2023
@dagardner-nv dagardner-nv deleted the branch-23.11-boost-vers branch September 11, 2023 16:18
dagardner-nv added a commit to dagardner-nv/MRC that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: Intermittent test failures for clang & gcc-coverage
3 participants