Update cast_from_pyobject to throw on unsupported types rather than returning null #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagardner-nv
changed the title
mdemoret-nv
approved these changes
Mar 11, 2024
…ception Remove uneeded as_string method
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-24.03 #451 +/- ##
================================================
- Coverage 73.81% 73.80% -0.01%
================================================
Files 398 398
Lines 14228 14239 +11
Branches 1108 1111 +3
================================================
+ Hits 10502 10509 +7
- Misses 3726 3730 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
/merge |
2 tasks
dagardner-nv
added a commit
to dagardner-nv/MRC
that referenced
this pull request
Apr 4, 2024
…tores previous behavior prior to PR nv-morpheus#451
This was referenced Apr 4, 2024
rapids-bot bot
pushed a commit
to nv-morpheus/Morpheus
that referenced
this pull request
Apr 5, 2024
* Fixes an issue where the `--start_time` flag was being ignored * Prior to nv-morpheus/MRC#451 the `datetime` objects being stored in the config were being serialized to json null, after that change an exception was raised. Closes #1590 ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1592
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cast_from_pyobjectencounters an unsupported type it returns a json null.pybind11::type_error, matching theTypeErrorexception raised by the Python stdjson.dumpsmethod.get_py_type_namehelper methodCloses #450
Checklist